Skip to content

Brute-force propagate let types upward to resolve specialization issue #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

Brute-force propagate let types upward to resolve specialization issue #1433

merged 4 commits into from
Mar 24, 2025

Conversation

stylewarning
Copy link
Member

(authored by @garlic0x1)

YarinHeffes
YarinHeffes requested changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@YarinHeffes YarinHeffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to fix #1390. I think we can merge this PR and close #1390, then open a new issue to resolve the let types earlier in the codegen.

@stylewarning stylewarning enabled auto-merge (squash) March 24, 2025 21:48
@stylewarning stylewarning mentioned this pull request Mar 24, 2025
Closed
@stylewarning stylewarning merged commit 2e0a8ae into main Mar 24, 2025
25 checks passed
@stylewarning stylewarning deleted the inline-specialized branch March 24, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarinHeffes YarinHeffes YarinHeffes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stylewarning @YarinHeffes @garlic0x1