Skip to content

feat(mcp): add ad4m://everyone to mention waker query#770

Open
data-bot-coasys wants to merge 2 commits into
devfrom
feat/everyone-mention
Open

feat(mcp): add ad4m://everyone to mention waker query#770
data-bot-coasys wants to merge 2 commits into
devfrom
feat/everyone-mention

Conversation

@data-bot-coasys

@data-bot-coasys data-bot-coasys commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds ad4m://everyone as a protocol-level group mention URI to the MCP mention waker config.

Changes

rust-executor/src/mcp/tools/subscriptions.rs

  • Added ad4m://everyone to the list of terms in get_mention_waker_config
  • All agents who regenerate their waker config will automatically match on group mentions

How It Works

When a message body contains ad4m://everyone, the waker's SurrealQL subscription matches it via the existing fn::contains mechanism. All agents with mention subscriptions in that neighbourhood get woken.

Related

Closes #769

Summary by CodeRabbit

  • New Features
    • Protocol-wide group mentions are now properly recognized and trigger notifications. The system now detects when messages contain group mention strings in addition to individual mentions.

Adds ad4m://everyone as a protocol-level group mention URI.
When any message body contains ad4m://everyone, all agents
with mention subscriptions in that neighbourhood will be woken.

This adds ad4m://everyone to the list of terms in
get_mention_waker_config, so agents who regenerate their waker
config will automatically match on group mentions.

Closes #769
@coderabbitai

coderabbitai Bot commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4030f571-1e7f-4dcf-88c6-457bcb72bdbe

📥 Commits

Reviewing files that changed from the base of the PR and between 51e92a7 and e08319f.

📒 Files selected for processing (1)
  • rust-executor/src/mcp/tools/subscriptions.rs

📝 Walkthrough

Walkthrough

The mention-waker subscription query is enhanced to include ad4m://everyone in its search-term set, enabling waker notifications when protocol-wide group mentions appear in message content.

Changes

Cohort / File(s) Summary
Mention-Waker Query Enhancement
rust-executor/src/mcp/tools/subscriptions.rs
Added ad4m://everyone string to the all_terms set used in mention-waker query construction to detect protocol-wide group mentions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • #769: This PR implements the core requirement to support ad4m://everyone mention URIs in the waker subscription query logic.

Possibly related PRs

Poem

🐰 A whisper through the network wide,
ad4m://everyone added with pride,
When mentions flow for all to hear,
The waker wakes—loud and clear! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding ad4m://everyone to the mention waker query, which is the primary focus of this PR.
Linked Issues check ✅ Passed The PR fully implements the primary coding requirement from #769: adding ad4m://everyone to get_mention_waker_config so the existing SurrealQL subscription logic will match on group mentions.
Out of Scope Changes check ✅ Passed The PR contains only in-scope changes directly addressing the linked issue. The modification adds ad4m://everyone to the mention waker query as required, with no extraneous alterations.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/everyone-mention

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Support ad4m://everyone and ad4m://here mention URIs in waker

2 participants