Skip to content

Release AArch64 for macOS instead of x86-64 #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AustinWise
Copy link
Contributor

@AustinWise AustinWise commented Apr 6, 2025

For the last several release builds the macOS x86-64 build has failed. See this release for example. The reason is the SASS C library is being built for AArch64 while Cobalt is being built for x86-64. Example error message:

note: ld: warning: ignoring file '/Users/runner/work/cobalt.rs/cobalt.rs/target/x86_64-apple-darwin/release/deps/libsass_sys-2120902d259b8636.rlib[68](base64vlq.o)': found architecture 'arm64', required architecture 'x86_64'

Rather than figuring out how to fix the x64 build for macOS, I have switch the build to AArch64. I confirmed in my fork that CI builds and that the resulting binary at least can start up.

The reasons for switching the target for macOS rather than trying to fix x64 include:

  • x64 was already broken and this was a 1-line fix to add an architecture for macOS.
  • The SASS library is deprecated (see RUSTSEC-2021-0136: sass-rs has been deprecated #1050) and archived on GitHub, so if fixing the build problem required changing the upstream, we would have to fork the library.
  • AArch64 Macs began selling almost 5 years ago, so at this point many macOS users can probably run AArch64 binaries.

@AustinWise AustinWise marked this pull request as draft April 6, 2025 22:17
@AustinWise AustinWise marked this pull request as ready for review April 6, 2025 22:23
@epage
Copy link
Member

epage commented Apr 10, 2025

Thanks for pointing this out!

I've instead done a separate push as I did a general update to my template for pre-built binaries.

@epage epage closed this Apr 10, 2025
@AustinWise
Copy link
Contributor Author

Thanks, looks good!

@AustinWise AustinWise deleted the austin/macos-arm64 branch April 10, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants