Skip to content

images: rhel: install vdo support #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Conversation

jelly
Copy link
Member

@jelly jelly commented May 15, 2025

The out of tree kernel driver has been upstreamed to the mainline kernel in the form of dm-vdo.

  • image-refresh rhel-10-1

The out of tree kernel driver has been upstreamed to the mainline kernel
in the form of dm-vdo.
@jelly jelly added the bot label May 15, 2025
@cockpituous cockpituous changed the title images: rhel: install vdo support WIP: c27d0795a5ec: [no-test] images: rhel: install vdo support May 15, 2025
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: c27d0795a5ec: [no-test] images: rhel: install vdo support images: rhel: install vdo support May 15, 2025
@jelly
Copy link
Member Author

jelly commented May 15, 2025

I will test vdo support later in cockpit, but we need this package regardless. I think?

@jelly
Copy link
Member Author

jelly commented May 15, 2025

Let's HOLD, this for now and first check if we need:

/usr/bin/vdoforcerebuild
/usr/bin/vdoformat
/usr/bin/vdostats

@jelly
Copy link
Member Author

jelly commented May 15, 2025

This is being tested in cockpit-project/cockpit#22008 and for TV watchers, click here

@jelly jelly requested a review from mvollmer May 15, 2025 10:38
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense. We don't need vdoformat etc, but lvm2 maybe does. And dm--vdo is part of the kernel now, so we don't need any package for the kernel module.
Thanks!

@jelly
Copy link
Member Author

jelly commented May 16, 2025

Yes, makes sense. We don't need vdoformat etc, but lvm2 maybe does. And dm--vdo is part of the kernel now, so we don't need any package for the kernel module. Thanks!

Yup lvm2 does, https://github.com/lvmteam/lvm2/blob/37b28216fd029ffe2fac815b16645aeb9d352235/lib/metadata/vdo_manip.c#L245

@jelly jelly merged commit 31cea31 into cockpit-project:main May 16, 2025
15 checks passed
@jelly jelly deleted the rhel-10-vdo branch May 16, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants