Directly use fsinfo state #434
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cockpituous
reviewed
May 7, 2024
| } else if (fileInfo?.type === "lnk") { | ||
| modalTitle = cockpit.format( | ||
| forceDelete ? _("Force delete link $0?") : _("Delete link $0?"), selectedItem.name | ||
| forceDelete ? _("Force delete link $0?") : _("Delete link $0?"), selected[0] |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
| } else if (fileInfo?.type === "dir") { | ||
| modalTitle = cockpit.format( | ||
| forceDelete ? _("Force delete directory $0?") : _("Delete directory $0?"), selectedItem.name | ||
| forceDelete ? _("Force delete directory $0?") : _("Delete directory $0?"), selected[0] |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
| ); | ||
| } else { | ||
| modalTitle = cockpit.format(forceDelete ? _("Force delete $0") : _("Delete $0?"), selectedItem.name); | ||
| modalTitle = cockpit.format(forceDelete ? _("Force delete $0") : _("Delete $0?"), selected[0]); |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+200
to
+202
| } else if (fileInfo?.type === "lnk") { | ||
| title = cockpit.format(_("Rename link $0"), selected); | ||
| } else if (fileInfo?.type === "dir") { |
Contributor
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
| title = cockpit.format(_("Rename directory $0"), selected); | ||
| } else { | ||
| title = _("Rename $0", selected.name); | ||
| title = _("Rename $0", selected); |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
| id: "copy-item", | ||
| title: _("Copy"), | ||
| onClick: () => setClipboard([currentPath + selected[0].name]), | ||
| onClick: () => setClipboard([currentPath + selected[0]]), |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
| id: "paste-into-directory", | ||
| title: _("Paste into directory"), | ||
| onClick: () => spawnPaste(clipboard, [currentPath + selected[0].name]), | ||
| onClick: () => spawnPaste(clipboard, [currentPath + selected[0]]), |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
| id: "copy-item", | ||
| title: _("Copy"), | ||
| onClick: () => setClipboard(selected.map(s => path.join("/") + "/" + s.name)), | ||
| onClick: () => setClipboard(selected.map(s => path.join("/") + "/" + s)), |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
| const onDoubleClickNavigate = useCallback((filename) => { | ||
| const newPath = [...path, filename].join("/"); | ||
| const file = files[filename]; | ||
| if (files && (file.type === "dir" || file.to === "dir")) { |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
| return "directory-item"; | ||
| } else if (file.type === "lnk" && file?.to === "dir") { | ||
| // TODO: info.target(name)?.type | ||
| } else if (file.type === "lnk" && cwdInfo?.targets[filename]?.type === "dir") { |
Contributor
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some research upfront would be nice: