Skip to content

Conversation

@jelly
Copy link
Member

@jelly jelly commented Sep 5, 2024

No description provided.

@jelly jelly requested a review from garrett September 5, 2024 10:33
@garrett
Copy link
Member

garrett commented Sep 9, 2024

Do we have a way to determine if we need to show the viewer instead of the editor?

(It would probably be better to have "Edit file" and "View file".)

@jelly
Copy link
Member Author

jelly commented Sep 17, 2024

Do we have a way to determine if we need to show the viewer instead of the editor?

(It would probably be better to have "Edit file" and "View file".)

Only if we execute test -w when one selects a file, that was I guess deemed to expensive and doing it based on permissions is fragile.

@jelly
Copy link
Member Author

jelly commented Feb 7, 2025

As we discussed today, we seem to agree that calling test -w is worth it when opening a menu to avoid further conflicts I'll first wait on #880 to be merged.

@jelly jelly added the blocked Don't land until something else happens first (see task list) label Feb 7, 2025
@jelly
Copy link
Member Author

jelly commented Jun 6, 2025

@allisonkarlitskaya re-investigating this one, and now that we have w-ok we can make this happen :)

Are you of the opinion that it is fine to fetch w-ok for all files or shall we restrict it to just the directory? As in adding a separate fsinfo on directory load which fetches the access bits of the directory.

Of course the idea is that this is a hint, if anything changes we should still handle this gracefully so fall back to read only mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Don't land until something else happens first (see task list)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants