Add padding to edges of file list, and compensate spacing in details and grid #924
Conversation
jelly
left a comment
jelly
left a comment
There was a problem hiding this comment.
This introduces a regression where the last row has an underline
| &.view-details { | ||
| --icon-size: 16px; | ||
| --pf-v5-c-table--m-compact--cell--first-last-child--PaddingLeft: var(--pf-v5-global--spacer--md); | ||
| --pf-v5-c-table--m-compact--cell--first-last-child--PaddingRight: var(--pf-v5-global--spacer--md); |
There was a problem hiding this comment.
Would be nice to know where this exactly comes from, for when we try to look into PF6
There was a problem hiding this comment.
It's in the table component, used in the cells, in the compact variant... according to the variable naming. As the component variables are defined in the toplevel component, that's where I changed it here (rather than lower in the stack).
I don't think it does code-wise, even if it does show up visually. It's probably just that it's more visible now instead. Perhaps I changed margin to 0 instead of -1px or something like that. But, yeah, we should fix it. |
|
@Venefilyn would you mind taking over this PR if interested? Otherwise I'll take a look. |
2 participants
Mostly fixes #787 by adding a bit of padding around the list (and trimming some spacing inside the details and grid views).
However, it'd probably also be a good idea to show the folder's context menu when you right click the grey background gutter area.