Console resize and scale settings #2015
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mvollmer
force-pushed
the
console-resize-scale-settings
branch
from
9ba55bf to
5c152a3
Compare
This was referenced Feb 5, 2025
mvollmer
force-pushed
the
console-resize-scale-settings
branch
from
5c152a3 to
10c0001
Compare
mvollmer
force-pushed
the
console-resize-scale-settings
branch
from
10c0001 to
1bde77f
Compare
|
Just checked the new demo and it looks great! |
mvollmer
force-pushed
the
console-resize-scale-settings
branch
from
82c6141 to
2568222
Compare
mvollmer
force-pushed
the
console-resize-scale-settings
branch
from
2568222 to
0d7531b
Compare
mvollmer
changed the title
mvollmer
force-pushed
the
console-resize-scale-settings
branch
from
0d7531b to
47978a9
Compare
- A ToggleGroup in the Card header is used to switch consoles - The console switcher is also there for shut-off machines. This gives us a place for type-specific actions that also make sense for a shut-off machine, like editing VNC server settings. - The DesktopViewer is gone, but there is a footer with a "Launch viewer" button and a "How to connect" popover. - Actions for the Graphics and Serial consoles are collected into kebab menus. - The expanded console has less UI around it, and it keeps the type that was active in the collapsed view. Instead of the breadcrumb it has a "Collapse" button. - When there is no actual console for a given type, there is now a EmptyState component where you can enable it. - It is possible to change VNC server settings via the "How to connect" popup. - The SPICE console invites you to replace it with VNC. - The size of the expanded console is now always controlled by the browser window and never overflows in height. - The VncConsole has been imported from @patternfly/react-console and stripped down.
mvollmer
force-pushed
the
console-resize-scale-settings
branch
from
47978a9 to
1d2289c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COCKPIT-1243
The Machines application of Cockpit lets people interact with the graphical console of a virtual machine. This is useful for baby sitting a VM through its boot process or doing the occasional rescue work, but it might also be used to do real day-to-day work in a graphical desktop environment that runs in the VM.
The graphical console in Cockpit Machines is fundamentally limited by having to run in a browser. The browser might eat some keys, for example, and serious work might thus require a external viewer application such as GNOME Connections, TigerVNC, or virt-viewer. Nevertheless, we should make Cockpit's own viewer work as well as possible.
Purpose
The purpose of this task is to improve our own VNC viewer by giving the user control over its resizing and scaling behavior. It should be possible to avoid any scaling and get a 1-to-1 pixel perfect view of a remote desktop, and it should be possible to avoid sending resize requests to a remote desktop.
Demo: https://youtu.be/gXrWcJHXn8s