users: Fix double-rendering of user fields #21865
Draft
+55
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within user details there was an issue where if you modify something like "Disallow interactive password" you would get two renders following the information from cockpit. First render didn't change the state at all whereas the second render did. However, if the second render is a bit slower enough this would cause visual rendering changes that look very jarring. With this an OUIA Ready flag has been added to the checkbox as well to signify that the checkbox is not waiting for anything. Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn
added
no-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within user details there was an issue where if you modify something
like "Disallow interactive password" you would get two renders following
the information from cockpit. First render didn't change the state at
all whereas the second render did. However, if the second render is a
bit slower enough this would cause visual rendering changes that look
very jarring.
With this an OUIA Ready flag has been added to the checkbox as well to
signify that the checkbox is not waiting for anything.
Signed-off-by: Freya Gustavsson [email protected]