apps: Fix alignment of application list #21946
Open
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Venefilyn - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the
margin-blockis set to-4px.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
With this we fix the alignment of applications to remove the centering and instead change the alignment of the app icons themselves. This will improve the mobile layout as well and ensure that the text, icon, and button for installing/removing is all aligned correctly. Fixes: cockpit-project#21878 Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn
force-pushed
the
apps/button-alignment
branch
from
22d45c6 to
301d596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we fix the alignment of applications to remove the centering
and instead change the alignment of the app icons themselves. This will
improve the mobile layout as well and ensure that the text, icon, and
button for installing/removing is all aligned correctly.
Fixes: #21878
Signed-off-by: Freya Gustavsson [email protected]