-
Notifications
You must be signed in to change notification settings - Fork 1.2k
examples/long-running-process: Add reset #21995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @TypicalRenegade , thanks for this nice improvement! One round of small cleanups, and I'm happy to land it.
Sorry for the delay! The team is a bit underpowered this quarter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This works nicely now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the tests actually cover a failing service, and need to be adjusted. I can do that.
When a launched process has failed, the run button will change to "Reset" and will reset the unit so it can be ran again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test adjusted, and I squashed your commits. Thanks!
You're welcome :)
Sent from Proton Mail Android
…-------- Original Message --------
On 5/27/25 10:29 PM, Martin Pitt wrote:
@martinpitt approved this pull request.
Test adjusted, and I squashed your commits. Thanks!
—
Reply to this email directly, [view it on GitHub](#21995 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BR62A3DXLWDWZOV42XGC3YL3AVCVHAVCNFSM6AAAAAB4664NWKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNZTGYZTINBTGI).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
When I was creating a module for cockpit that used the LongRunningProcess Example I found that while debugging the module I made there wasn't a way to reset the process without going to the terminal (with the proper command) to reset the process if it failed.
So, I created a way and thought I would share it.