examples/long-running-process: Add reset #21995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
requested changes
May 20, 2025
There was a problem hiding this comment.
Hello @TypicalRenegade , thanks for this nice improvement! One round of small cleanups, and I'm happy to land it.
Sorry for the delay! The team is a bit underpowered this quarter.
martinpitt
approved these changes
May 28, 2025
martinpitt
requested changes
May 28, 2025
When a launched process has failed, the run button will change to "Reset" and will reset the unit so it can be ran again.
martinpitt
changed the title
martinpitt
approved these changes
May 28, 2025
|
You're welcome :)
Sent from Proton Mail Android
…-------- Original Message --------
On 5/27/25 10:29 PM, Martin Pitt wrote:
@martinpitt approved this pull request.
Test adjusted, and I squashed your commits. Thanks!
—
Reply to this email directly, [view it on GitHub](#21995 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BR62A3DXLWDWZOV42XGC3YL3AVCVHAVCNFSM6AAAAAB4664NWKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNZTGYZTINBTGI).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was creating a module for cockpit that used the LongRunningProcess Example I found that while debugging the module I made there wasn't a way to reset the process without going to the terminal (with the proper command) to reset the process if it failed.
So, I created a way and thought I would share it.