Skip to content

examples/long-running-process: Add reset #21995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

TypicalRenegade
Copy link
Contributor

When I was creating a module for cockpit that used the LongRunningProcess Example I found that while debugging the module I made there wasn't a way to reset the process without going to the terminal (with the proper command) to reset the process if it failed.

So, I created a way and thought I would share it.

@martinpitt martinpitt self-requested a review May 19, 2025 10:05
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @TypicalRenegade , thanks for this nice improvement! One round of small cleanups, and I'm happy to land it.

Sorry for the delay! The team is a bit underpowered this quarter.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This works nicely now.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the tests actually cover a failing service, and need to be adjusted. I can do that.

When a launched process has failed, the run button will change to
"Reset" and will reset the unit so it can be ran again.
@martinpitt martinpitt changed the title LongRunningProcess Example -- Reset Process Addition examples/long-running-process: Add reset May 28, 2025
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test adjusted, and I squashed your commits. Thanks!

@martinpitt martinpitt merged commit cb27ab1 into cockpit-project:main May 28, 2025
25 of 88 checks passed
@TypicalRenegade
Copy link
Contributor Author

TypicalRenegade commented May 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants