storage: Fix section spacing #22011
storage: Fix section spacing #22011
Conversation
|
This would remove the border on mobile as can be seen here is that expected? |
We had a bit too much spacing between cards that caused issues with storage mobile-view. Reverting this to how we had it before. This also removes the border between cards for the storage page and instead only keeps them for the table-style of cards we have between storage types. Future improvements would be to - Remove usage of Card for Storage page sections or embrace it fully - Remove usage of Card for mobile-view rows and instead use Table or Data list component Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2366666 Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
a9f6661 to
e906b47
Compare
Yeah maybe not the best. I added the border back in for table cards so will look like before but without the extra spacing at least |
| @@ -350,12 +350,9 @@ $phone: 767px; | |||
| } | |||
|
|
|||
| /* FIXME: Temporary rework plain cards to make it look like how PF6 is designed, adding borders between sections */ | |||
| .pf-v6-c-card.pf-m-plain + .pf-v6-c-card.pf-m-plain, | |||
| .pf-v6-l-stack__item + .pf-v6-l-stack__item > .pf-v6-c-card.pf-m-plain { | |||
| .pf-v6-c-card.ct-small-table-card { | |||
There was a problem hiding this comment.
hm that only applies to storage, interesting. I assume this still changes other projects
There was a problem hiding this comment.
This remove borders, as the rule does not apply seemingly anymore (according to pixel tests)
I think we probably want to keep the selectors above, and just remove the padding-block-start.
There was a problem hiding this comment.
According to pixel tests it also affects accounts, selinux, storage.
There was a problem hiding this comment.
@KKoukiou the selectors I changed because it modifies not only the table like stuff we have that have cards for rows. But also page sections themselves.
The border between sections causes extra confusion and the spacing there doesn't matter. So the whole section can be dropped from those parts of the UI.
Does that make sense? It's just to change the selectors from everything to just card tables
There was a problem hiding this comment.
yes now I see. agreed this is the desired change.
We had a bit too much spacing between cards that caused issues with
storage mobile-view. Reverting this to how we had it before.
This also removes the border between cards for the storage page
and instead only keeps them for the table-style of cards we have between
storage types.
Future improvements would be to
Data list component
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2366666
Signed-off-by: Freya Gustavsson [email protected]