storage: Fix section spacing #22011
Merged
storage: Fix section spacing #22011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would remove the border on mobile as can be seen here is that expected? |
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
a9f6661 to
e906b47
Compare
Yeah maybe not the best. I added the border back in for table cards so will look like before but without the extra spacing at least |
jelly
reviewed
May 21, 2025
KKoukiou
previously approved these changes
May 22, 2025
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
e906b47 to
505515f
Compare
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
505515f to
cceb7b5
Compare
|
The pixel tests now conflict. |
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
2 times, most recently
from
237df40 to
7e0803b
Compare
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
7e0803b to
3be916b
Compare
jelly
reviewed
Jul 1, 2025
| @@ -350,12 +350,9 @@ $phone: 767px; | |||
| } | |||
|
|
|||
| /* FIXME: Temporary rework plain cards to make it look like how PF6 is designed, adding borders between sections */ | |||
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
3be916b to
7656510
Compare
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
3 times, most recently
from
7f21340 to
5a197f2
Compare
jelly
added
the
no-test
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
5a197f2 to
3a4b787
Compare
We had a bit too much spacing between cards that caused issues with storage mobile-view. Reverting this to how we had it before. This also removes the border between cards for the storage page and instead only keeps them for the table-style of cards we have between storage types. Future improvements would be to - Remove usage of Card for Storage page sections or embrace it fully - Remove usage of Card for mobile-view rows and instead use Table or Data list component Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2366666 Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn
force-pushed
the
storage/remove-extra-spacing
branch
from
3a4b787 to
fbf1c8c
Compare
jelly
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bit too much spacing between cards that caused issues with
storage mobile-view. Reverting this to how we had it before.
This also removes the border between cards for the storage page
and instead only keeps them for the table-style of cards we have between
storage types.
Future improvements would be to
Data list component
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2366666
Signed-off-by: Freya Gustavsson [email protected]