storage: Warn when renaming the volume group that contains the root filesystem #22024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
storage-warn-when-renaming-root-vgroup
branch
2 times, most recently
from
bb90713 to
234e6ef
Compare
mvollmer
added
the
no-test
mvollmer
force-pushed
the
storage-warn-when-renaming-root-vgroup
branch
from
234e6ef to
4ab01e1
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
storage-warn-when-renaming-root-vgroup
branch
from
4ab01e1 to
03dcef7
Compare
mvollmer
commented
May 21, 2025
pkg/storaged/lvm2/volume-group.jsx
Outdated
| ], | ||
| Action: { | ||
| Title: _("Rename"), | ||
| Danger: contains_rootfs(client, vgroup.path) ? _("This volume group contains the root filesystem. Renaming it might require further changes to the bootloader configuration or kernel command line.") : null, |
Member
Author
There was a problem hiding this comment.
I don't understand this. The tests cover both scenarios, renaming the rootfs, and renaming something else.
martinpitt
requested changes
May 22, 2025
Member
martinpitt
left a comment
martinpitt
left a comment
There was a problem hiding this comment.
Thanks! Depending on your patience/workload I'd prefer a cleanup round, but if you are under pressure I can be talked into 👍 'ing 😁
…ilesystem Because that might break the next boot. Fixes cockpit-project#20815
mvollmer
force-pushed
the
storage-warn-when-renaming-root-vgroup
branch
from
03dcef7 to
993bd7f
Compare
Member
Author
Always! It's much better now, thanks! |
martinpitt
approved these changes
May 27, 2025
Member
martinpitt
left a comment
martinpitt
left a comment
There was a problem hiding this comment.
Happy CI wife, happy life! I guess/hope that this is a flake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because that might break the next boot.
Fixes #20815