Fix motd message appearing when cockpit-ws is installed without cockpit #22610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all motd/issue symlink creation logic and related files from cockpit-ws to the main cockpit package. This ensures the symlinks and issue service are only present when cockpit is actually installed, preventing the motd message from appearing when cockpit-ws is installed as a dependency for anaconda-webui without the main cockpit package being installed. Resolves: rhbz#2412241
Member
|
Thanks @KKoukiou ! That will need some work (not necessarily from you) to complete. The tests need to be adjusted, the same should be applied to debian packaging, and we really need to test upgrades -- normally you have to declare that files move between packages, to cover "bad" upgrade orderings and overwriting files owned by (old) other packages. I.e. in debian/control that needs a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all motd/issue symlink creation logic and related files from cockpit-ws to the main cockpit package.
This ensures the symlinks and issue service are only present when cockpit is actually installed, preventing the motd message from appearing when cockpit-ws is installed as a dependency for anaconda-webui without the main cockpit package being installed.
Resolves: rhbz#2412241