Kubernetes: Display the NodePort in the service details #4110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -431,7 +431,7 @@ angular.module('kubernetesUI').run(['$templateCache', function($templateCache) { | |||
| " <dd>\n" + | |||
| " <div ng-if=\"!resource.spec.ports.length\">None</div>\n" + | |||
| " <div ng-repeat=\"portMapping in resource.spec.ports | orderBy:'port'\">\n" + | |||
| " {{portMapping.port}} → {{portMapping.targetPort}} ({{portMapping.protocol}})\n" + | |||
| " {{portMapping.port}} → {{portMapping.targetPort}} ({{portMapping.protocol}}) {{portMapping.nodePort?'NodePort: '+portMapping.nodePort:''}}\n" + | |||
There was a problem hiding this comment.
I would suggest using a tag like this: <span ng-if='portMapping.nodePort' translatable="yes">Node Port:</span> since it allows for translation and doesn't mix labels with the values.
The object-describer comes from another repository. Could you also submit a pull request upstream?
|
Thanks for the fix. Just a couple review comments above. I'd be happy to help on |
|
Haven't heard back, so I made those fixes and merged. Opened this pull request too: kubernetes-ui/object-describer#30 Hope I got this right.
|
|
Sorry for the delay @stefwalter and thank you for the change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.