Skip to content

release-25.2: changefeedccl: add timeout to nemeses test inserts #146312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rharding6373
Copy link
Collaborator

@rharding6373 rharding6373 commented May 7, 2025

Backport 1/1 commits from #146248 on behalf of @rharding6373.


Some mutation queries take a long time to plan and execute even if they're safe. This PR adds a short timeout to each mutation, like tlp does for mutations, in order to avoid hanging.

Fixes: #146159
Epic: none

Release note: none


Release justification: Test-only change to reduce flakiness

Some mutation queries take a long time to plan and execute even if
they're safe. This PR adds a short timeout to each mutation, like tlp
does for mutations, in order to avoid hanging.

Fixes: cockroachdb#146159
Epic: none

Release note: none
@rharding6373 rharding6373 force-pushed the blathers/backport-release-25.2-146248 branch from 873ebf2 to ed1a237 Compare May 7, 2025 19:39
@rharding6373 rharding6373 requested a review from a team as a code owner May 7, 2025 19:39
@rharding6373 rharding6373 requested review from andyyang890 and removed request for a team May 7, 2025 19:39
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 7, 2025
@blathers-crl blathers-crl bot requested a review from aerfrei May 7, 2025 19:39
Copy link

blathers-crl bot commented May 7, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 7, 2025
Copy link

blathers-crl bot commented May 7, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rharding6373
Copy link
Collaborator Author

TFTR! I guess this PR isn't recognized as test-only by the bot.

@rharding6373 rharding6373 merged commit 94ecfcb into cockroachdb:release-25.2 May 8, 2025
14 of 15 checks passed
@rharding6373 rharding6373 deleted the blathers/backport-release-25.2-146248 branch May 8, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-25.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants