release-25.1: security: update TestTLSCipherRestrict test setup #146316
+98
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #146177 on behalf of @souravcrl.
Current test setup starts the test server only once and runs various tls cipher
configurations but this seems to fail the test as final cipher configuration set
by previous run of the test may not be overridden by current run, and we have
stale ciphers configured for the subtest. Another issue is the timout being set
is 2s which may fail and increasing it is not possible as the test may timeout
before that leading to leaky goroutines. Hence, handling the http client
response timeouts as a flake. Waitgroups are added for all client calls to
ensure there are no open connections during test breakdown.
fixes #145812
fixes #145527
fixes #145459
fixes #145313
Release Note: None
Release justification: needed to fix failing CI