Skip to content

release-25.2: sql: maintain index dependencies during truncate #146326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

spilchen
Copy link
Contributor

@spilchen spilchen commented May 7, 2025

Backport 1/1 commits from #146287 on behalf of @spilchen.


When a table is truncated, new IDs are assigned to all its indexes. However, we previously failed to update any existing back-references to these index IDs in the table descriptor. This prevented the truncate from succeeding.

This change ensures that all references to old index IDs are properly remapped to the new ones, which allows the truncate to succeed.

Fixes #146065

Epic: none
Release note (bug fix): Fixed a bug that prevented TRUNCATE from succeeding if any indexes on the table had back-reference dependencies, such as from a view or function referencing the index.


Release justification: low-risk bug fix that unblocks TRUNCATE

When a table is truncated, new IDs are assigned to all its indexes.
However, we previously failed to update any existing back-references to these
index IDs in the table descriptor. This prevented the truncate from
succeeding.

This change ensures that all references to old index IDs are properly
remapped to the new ones, which allows the truncate to succeed.

Fixes cockroachdb#146065

Epic: none
Release note (bug fix): Fixed a bug that prevented TRUNCATE from
succeeding if any indexes on the table had back-reference dependencies,
such as from a view or function referencing the index.
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 7, 2025
@blathers-crl blathers-crl bot requested a review from rafiss May 7, 2025 20:56
Copy link

blathers-crl bot commented May 7, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 7, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@spilchen spilchen self-assigned this May 8, 2025
@spilchen spilchen merged commit 98a38e4 into cockroachdb:release-25.2 May 8, 2025
14 of 15 checks passed
@spilchen spilchen deleted the blathers/backport-release-25.2-146287 branch May 8, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-25.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants