Skip to content

kvserver: introduce setting to periodically reset split samples #146331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented May 7, 2025

Introduce a cluster setting kv.range_split.load_reset_duration which resets the load based splitter sampling after the set duration. When the set duration is zero, the load based splitter continues to only be reset when the per-second load falls below the load split threshold.

This setting may be useful when a range services a non-stationary load distribution, such that the initially sampled set of split keys are unsuitable to determine a split key from (e.g., all the same key) but a later sample set is suitable.

Informs: #144407
Release note: None

Introduce a cluster setting `kv.range_split.load_reset_duration` which
resets the load based splitter sampling after the set duration. When the
set duration is zero, the load based splitter continues to only be reset
when the per-second load falls below the load split threshold.

This setting may be useful when a range services a non-stationary
load distribution, such that the initially sampled set of split keys are
unsuitable to determine a split key from (e.g., all the same key) but a
later sample set is suitable.

Informs: cockroachdb#144407
Release note: None
@kvoli kvoli self-assigned this May 7, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli marked this pull request as ready for review May 8, 2025 13:41
@kvoli kvoli requested a review from a team as a code owner May 8, 2025 13:41
@kvoli kvoli requested a review from wenyihu6 May 8, 2025 13:41
@kvoli kvoli added backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1 backport-25.2.x Flags PRs that need to be backported to 25.2 labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1 backport-25.2.x Flags PRs that need to be backported to 25.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants