Skip to content

release-25.2: kvnemesis: test buffered writes for SSI transactions #146564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-25.2
Choose a base branch
from
Open

release-25.2: kvnemesis: test buffered writes for SSI transactions #146564

wants to merge 1 commit into from
+231 −18

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 12, 2025

Backport 1/1 commits from #143979 on behalf of @stevendanna.

This provides a new configuration option to enable write buffering for some SSI transactions during KVNemesis runs and adds a new test configuration that enables write buffering at a 70% probability.

To facilitate this, the write buffer now also tracks the KVNemesisSequence.

We only do this for SSI transactions as there are known issues with RC and SI transactions and write buffering.

Fixes #143893

Release note: None

Release justification:

@stevendanna
kvnemesis: test buffered writes for SSI transactions
6cf2eeb 
This provides a new configuration option to enable write buffering for
some SSI transactions during KVNemesis runs and adds a new test
configuration that enables write buffering at a 70% probability.

To facilitate this, the write buffer now also tracks the
KVNemesisSequence. We only track the most recent sequence number since
that is what will get sent when flushing.

Further, we now track the flushed state separately from the enabled
state to handle stateful transaction retries.

We only do this for SSI transactions as there are known issues with RC
and SI transactions and write buffering.

Fixes #143893

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 12, 2025 16:49
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 12, 2025
@blathers-crl blathers-crl bot requested review from arulajmani and miraradeva May 12, 2025 16:49
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented May 12, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from stevendanna May 12, 2025 16:49
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 12, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraradeva miraradeva miraradeva approved these changes

@arulajmani arulajmani Awaiting requested review from arulajmani

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees

@stevendanna stevendanna

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @miraradeva @stevendanna