Skip to content

release-25.1: distsql: cancel remote flows on quiesce #146574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented May 12, 2025

Backport 1/1 commits from #143990 on behalf of @yuzefovich.


We recently saw a test timeout where the cluster shutdown was blocked on the outbox goroutine attempting to set up a connection to one of the nodes. We blocked there indefinitely since the remote flows previously didn't respect quiesce signal (we're using the background context there because the remote flows outlive the SetupFlow RPC handler context). This is now fixed.

The bug has been present since forever, and given that we haven't hit this before, it seems like an extreme edge case, so I decided to omit the release note.

Fixes: #143875.

Release note: None


Release justification: low-risk node shutdown fix.

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 12, 2025
@blathers-crl blathers-crl bot requested review from DrewKimball and mgartner May 12, 2025 17:56
Copy link

blathers-crl bot commented May 12, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 12, 2025
Copy link

blathers-crl bot commented May 12, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

We recently saw a test timeout where the cluster shutdown was blocked on
the outbox goroutine attempting to set up a connection to one of the
nodes. We blocked there indefinitely since the remote flows previously
didn't respect quiesce signal (we're using the background context there
because the remote flows outlive the SetupFlow RPC handler context).
This is now fixed.

The bug has been present since forever, and given that we haven't hit
this before, it seems like an extreme edge case, so I decided to omit
the release note.

Release note: None
@yuzefovich yuzefovich force-pushed the blathers/backport-release-25.1-143990 branch from 2746817 to 059915d Compare May 12, 2025 22:34
@yuzefovich yuzefovich merged commit 391aaef into cockroachdb:release-25.1 May 13, 2025
14 of 15 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-25.1-143990 branch May 13, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-25.1.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants