Skip to content

staging-v24.3.13: admission: increase file count based overload threshold #146597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 12, 2025

Backport 1/1 commits from #145919 on behalf of @blathers-crl[bot].


Backport 1/1 commits from #138699 on behalf of @sumeerbhola.


The current value of 1000 was too inconsistent with Pebble's compaction scoring, in that compaction scoring had 1 sub-level == 500 L0 files, and admission control had 1 sub-level == 50 L0 files. The value is increased to 4000, so 1 sub-level == 200 L0 files. There is a long code comment elaborating on this.

Informs #138655

Epic: none

Release note (ops change): The default value of cluster setting admission.l0_file_count_overload_threshold is changed to 4000.


Release justification: Addresses insufficient tokens under high write load and WAL failover.


Release justification:

The current value of 1000 was too inconsistent with Pebble's compaction
scoring, in that compaction scoring had 1 sub-level == 500 L0 files, and
admission control had 1 sub-level == 50 L0 files. The value is increased
to 4000, so 1 sub-level == 200 L0 files. There is a long code comment
elaborating on this.

Informs #138655

Epic: none

Release note (ops change): The default value of cluster setting
admission.l0_file_count_overload_threshold is changed to 4000.
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 12, 2025 21:49
@blathers-crl blathers-crl bot force-pushed the blathers/backport-staging-v24.3.13-145919 branch from 30e774a to d0b3ce4 Compare May 12, 2025 21:49
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 12, 2025
Copy link
Author

blathers-crl bot commented May 12, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 12, 2025
Copy link
Author

blathers-crl bot commented May 12, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@celiala celiala changed the title staging-v24.3.13: release-24.3: admission: increase file count based overload threshold staging-v24.3.13: admission: increase file count based overload threshold May 12, 2025
@celiala celiala merged commit 6d90a74 into staging-v24.3.13 May 13, 2025
13 checks passed
@celiala celiala deleted the blathers/backport-staging-v24.3.13-145919 branch May 13, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-24.3.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants