-
Notifications
You must be signed in to change notification settings - Fork 4.1k
*: enable more drpc tests #162062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cthumuluru-crdb
wants to merge
12
commits into
cockroachdb:master
Choose a base branch
from
cthumuluru-crdb:enable-sqlccl-drpc-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
*: enable more drpc tests #162062
cthumuluru-crdb
wants to merge
12
commits into
cockroachdb:master
from
cthumuluru-crdb:enable-sqlccl-drpc-tests
+36
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables DRPC randomly for all tests in the pkg/ccl/testccl/sqlccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
Member
This commit enables DRPC randomly for all tests in the pkg/ccl/multiregionccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/pgcryptoccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/sqlproxyccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/telemetryccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/utilccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/auditloggingccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/cliccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/importerccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/partitionccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/schemachangerccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
This commit enables DRPC randomly for all tests in the pkg/ccl/workloadccl package. All tests pass successfully with DRPC enabled across all tenant modes (default, shared, and external), verified with 10 runs each. Epic: CRDB-48935 Issue: None Release note: None
f536490 to
07676d7
Compare
suj-krishnan
approved these changes
Jan 30, 2026
Collaborator
suj-krishnan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
162062: *: enable more drpc tests r=cthumuluru-crdb a=cthumuluru-crdb Previously, tests in pkg/ccl/* packages did not exercise DRPC functionality. This change modifies the test initialization to randomly enable DRPC at the package level. All tests pass with DRPC enabled across default, shared, and external tenant modes (verified with 10 runs each). Epic: [CRDB-48935](https://cockroachlabs.atlassian.net/browse/CRDB-48935) Issue: None Release note: None Co-authored-by: Chandra Thumuluru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tests in pkg/ccl/* packages did not exercise DRPC functionality. This change modifies the test initialization to randomly enable DRPC at the package level.
All tests pass with DRPC enabled across default, shared, and external tenant modes (verified with 10 runs each).
Epic: CRDB-48935
Issue: None
Release note: None