Skip to content

Conversation

@cthumuluru-crdb
Copy link
Contributor

@cthumuluru-crdb cthumuluru-crdb commented Jan 30, 2026

Previously, tests in pkg/ccl/* packages did not exercise DRPC functionality. This change modifies the test initialization to randomly enable DRPC at the package level.

All tests pass with DRPC enabled across default, shared, and external tenant modes (verified with 10 runs each).

Epic: CRDB-48935
Issue: None
Release note: None

This commit enables DRPC randomly for all tests in the
pkg/ccl/testccl/sqlccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit enables DRPC randomly for all tests in the
pkg/ccl/multiregionccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/pgcryptoccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/sqlproxyccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/telemetryccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/utilccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/auditloggingccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/cliccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/importerccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/partitionccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/schemachangerccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
This commit enables DRPC randomly for all tests in the
pkg/ccl/workloadccl package.

All tests pass successfully with DRPC enabled across all tenant
modes (default, shared, and external), verified with 10 runs each.

Epic: CRDB-48935
Issue: None
Release note: None
@cthumuluru-crdb cthumuluru-crdb force-pushed the enable-sqlccl-drpc-tests branch from f536490 to 07676d7 Compare January 30, 2026 03:30
@cthumuluru-crdb cthumuluru-crdb marked this pull request as ready for review January 30, 2026 03:32
@cthumuluru-crdb cthumuluru-crdb requested review from a team as code owners January 30, 2026 03:32
Copy link
Collaborator

@suj-krishnan suj-krishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cthumuluru-crdb
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Jan 30, 2026
162062: *: enable more drpc tests r=cthumuluru-crdb a=cthumuluru-crdb

Previously, tests in pkg/ccl/* packages did not exercise DRPC functionality. This change modifies the test initialization to randomly enable DRPC at the package level.

All tests pass with DRPC enabled across default, shared, and external tenant modes (verified with 10 runs each).

Epic: [CRDB-48935](https://cockroachlabs.atlassian.net/browse/CRDB-48935)
Issue: None
Release note: None

Co-authored-by: Chandra Thumuluru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants