*: upgrade to go 1.19.1#86049
Conversation
|
This change is |
rickystewart
force-pushed
the
upgradego119
branch
5 times, most recently
from
2eda492 to
16f1412
Compare
rickystewart
requested review from
a team and
msbutler
and removed request for
a team
|
This is pretty close, can probably be merged soon. @knz Looks like that file is still problematic even after the cherry-pick? |
rickystewart
force-pushed
the
upgradego119
branch
from
9b642f4 to
d953ea2
Compare
Oh, maybe I messed up something with the rebase. I'm trying again now. |
|
You will probably need #87485 to get over the remaining linter hurdle. Then for the remaining test failure you need to update the expected test output (I think it's |
rickystewart
force-pushed
the
upgradego119
branch
2 times, most recently
from
52f65f5 to
a19e0af
Compare
I pulled the changes into this commit, except for the uses of AFAICT this is ready for review now. |
|
i can spend time on the detailed review but with focused chaos it will likely spread over 2-3 days. |
I'll check if there's someone on the team who has time to review. |
mari-crl
left a comment
mari-crl
left a comment
There was a problem hiding this comment.
Sanity check completed!
A lot of ASCII art in our codebase... Some of it seems like it may have gotten misaligned, but I don't think that's a fix to be made here. Get it in there!
Reviewed 766 of 789 files at r11, 24 of 24 files at r13, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @HonoreDB, @msbutler, and @srosenberg)
|
Btw 1.19.1 was just released with applicable security patches. IMHO it would be useful to have this done here right away. |
|
TFTR YOLO bors r=mari-crl p=99 |
|
👎 Rejected by label |
knz
left a comment
knz
left a comment
There was a problem hiding this comment.
I'm ok doing a post-hoc review on this.
Reviewed 7 of 789 files at r11.
Reviewable status:
rickystewart
force-pushed
the
upgradego119
branch
3 times, most recently
from
8c6e3ee to
0c786ee
Compare
* [ ] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new version and adjust SHA256 sums as necessary. * [x] Run the `Internal / Release / Build and Publish Patched Go` build configuration in TeamCity with your latest version of the script above. This will print out the new URL's and SHA256 sums for the patched Go that you built above. * [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above. * [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch @distdir//:archives` to ensure you've updated all hashes to the correct value. * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) Closes cockroachdb#85908. Release justification: Upgrade to latest Go version Release note (build change): upgrade to go 1.19.1
rickystewart
force-pushed
the
upgradego119
branch
from
0c786ee to
2675c7c
Compare
|
bors r=mari-crl,knz p=99 |
|
Build succeeded: |
11 participants
Internal / Release / Build and Publish Patched Gobuild configuration in TeamCity with your latest version of the script above. This will print out the new URL's and SHA256 sums for the patched Go that you built above.build/teamcity/internal/release/build-and-publish-patched-go/impl.shwith the new version and adjust SHA256 sums as necessary.WORKSPACEundergo_download_sdk. You may need to bump rules_go. Also edit the filenames listed insdksand update all the hashes to match what you built in the step above../dev generate bazelto refreshdistdir_files.bzl, thenbazel fetch @distdir//:archivesto ensure you've updated all hashes to the correct value.builder.shaccordingly (source).go-version-check.sh(source), unless bumping to a new patch release.go.mod. You may also need to rerunmake vendor_rebuildif vendoring has changed.bootstrap-debian.sh(source).golang:<old_version>andgo<old_version>).builder.dockerImageparameter in the TeamCityCockroachandInternalprojects.Closes #85908.
Release justification: Upgrade to latest Go version
Release note (build change): upgrade to go 1.19.1