Fix integer overflow on 32-bit architectures#23
Open
chrislusf wants to merge 2 commits intocockroachdb:mainfrom
Open
Fix integer overflow on 32-bit architectures#23chrislusf wants to merge 2 commits intocockroachdb:mainfrom
chrislusf wants to merge 2 commits intocockroachdb:mainfrom
Conversation
On 32-bit architectures (like OpenBSD ARM), int is 32-bit and cannot hold math.MaxInt64. Changed lPos and rPos to int64 to fix overflow errors when building for GOOS=openbsd GOARCH=arm.
On 32-bit architectures, EncodeFlags and FmtFlags need to be int64 to accommodate large bit shift operations that exceed 32 bits. This fixes overflow errors when building for GOOS=openbsd GOARCH=arm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On 32-bit architectures (such as OpenBSD ARM, Linux ARM, etc.), building the parser fails with integer overflow errors:
The issue occurs because:
inttype is 32-bit on 32-bit architecturesintcannot hold 64-bit values likemath.MaxInt64Solution
This PR changes the affected types from
inttoint64:lPosandrPosvariables frominttoint64to accommodatemath.MaxInt64EncodeFlagstype frominttoint64to support large bit shift operationsFmtFlagstype frominttoint64for the same reasonTesting
Successfully built and tested on:
GOOS=openbsd GOARCH=arm(32-bit)The changes are backward compatible since
int64is a superset ofinton all platforms.Impact