add TestData.String and use it for logging#54
Merged
RaduBerinde merged 1 commit intomasterfrom Apr 7, 2025
Merged
Conversation
tbg
approved these changes
Apr 5, 2025
8c4d03c to
75f2b5a
Compare
Member
Author
|
Also added a Since I'm here, would it help to indent the inputs/outputs and diffs? Current output: |
Member
Author
|
Indented would look like this (looks more readable to me): |
yuzefovich
approved these changes
Apr 7, 2025
Member
yuzefovich
left a comment
There was a problem hiding this comment.
I like the proposed indentation.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
75f2b5a to
3827628
Compare
Member
Author
|
TFTR! Added indentation. |
`TestData.String()` renders the entire testcase and we use it for better error and logging output. We also improve the logging output using better indentation.
3827628 to
379080b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestData.String()renders the entire testcase and we use it for better error and logging output.This change is