support scanning into all numeric types#58
Merged
RaduBerinde merged 1 commit intomasterfrom Sep 17, 2025
Merged
Conversation
tbg
approved these changes
Sep 17, 2025
Member
tbg
left a comment
tbg
left a comment
There was a problem hiding this comment.
Nice! I assume there's at least rudimentary test coverage of this through some existing test.
Member
Author
Yes, we test the types we were supporting before which is decent coverage. |
Use reflection to support scanning into any numeric types, including named types that have an underlying numeric type.
RaduBerinde
force-pushed
the
scan-more-types
branch
from
9af56a1 to
bc47c72
Compare
Member
Author
|
Added a test for |
jbowens
approved these changes
Sep 17, 2025
Contributor
jbowens
left a comment
jbowens
left a comment
There was a problem hiding this comment.
nice!
@jbowens reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
Member
Author
|
TFTRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use reflection to support scanning into any numeric types, including named types that have an underlying numeric type.
This change is