Skip to content

log position on fatal #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RaduBerinde merged 1 commit into from
Sep 18, 2025
Merged

log position on fatal #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions datadriven.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,15 @@ func runDirective(t testing.TB, r *testDataReader, f func(testing.TB, *TestData)

d := &r.data
actual := func() string {
fReturned := false
defer func() {
if r := recover(); r != nil {
t.Logf("\npanic during %s:\n%s\n", d.Pos, d.Input)
panic(r)
} else if !fReturned {
// t.Fatal calls runtime.Goexit() which runs the defers but there is no
// panic to recover.
t.Logf("\nfatal during %s:\n%s\n", d.Pos, d.Input)
}
}()

Expand All @@ -355,6 +360,7 @@ func runDirective(t testing.TB, r *testDataReader, f func(testing.TB, *TestData)
}()

actual := f(t, d)
fReturned = true
if actual != "" && !strings.HasSuffix(actual, "\n") {
actual += "\n"
}
Expand Down Expand Up @@ -855,6 +861,9 @@ func (td TestData) Logf(tb testing.TB, format string, args ...interface{}) {

// Fatalf wraps a fatal testing error with test file position information, so
// that it's easy to locate the source of the error.
//
// Note: tb.Fatalf can also be used directly; the test file position information
// will be logged.
func (td TestData) Fatalf(tb testing.TB, format string, args ...interface{}) {
tb.Helper()
tb.Fatalf("%s: %s", td.Pos, fmt.Sprintf(format, args...))
Expand Down