fix(memo): plumb state_methods through dataclass/pydantic fields#1971
Merged
Conversation
`_canonicalize_dataclass` and `_canonicalize_pydantic` recursed via `_canonicalize` without forwarding `state_methods`, so any `__coco_memo_state__` nested inside a dataclass or Pydantic field was silently dropped from the collected state-method list. Make `state_methods` a required positional `list[StateFnEntry]` on `_canonicalize`, `_make_call_canonical`, and `fingerprint_call` so every recursive site and every public caller is forced to thread it through. Callers that don't care (e.g. `memo_fingerprint`, tests that only check fingerprint equality) pass a throwaway empty list. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_canonicalize_dataclass/_canonicalize_pydantic: they recursed via_canonicalizewithout forwardingstate_methods, silently dropping any__coco_memo_state__nested inside a dataclass or Pydantic field.state_methodsa required positionallist[StateFnEntry]on_canonicalize,_make_call_canonical, andfingerprint_callso the bug class cannot recur — every recursive site and every public caller is forced to thread it through. Callers that don't care (e.g.memo_fingerprint, tests checking only fingerprint equality) pass[].test_state_methods_collected_through_dataclass_fieldandtest_state_methods_collected_through_pydantic_fieldcovering the bug.Test plan
CI (mypy + pytest cover the change).