Skip to content

fix(postgres): install pgvector extension into default schema #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeh0 merged 1 commit into from
May 15, 2026
Merged

fix(postgres): install pgvector extension into default schema #1979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions python/cocoindex/connectors/postgres/_target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,16 +961,17 @@ async def _drop_table(
async def _ensure_pgvector_extension(
self,
conn: asyncpg.pool.PoolConnectionProxy[asyncpg.Record],
pg_schema_name: str | None,
) -> None:
"""
Ensure the pgvector extension is installed.

Postgres extensions are installed per-database but can live in a chosen
schema; when `pg_schema_name` is provided we request installing into it.
The extension is installed into its default schema (typically `public`),
which is on the default `search_path`. We deliberately do not tie the
extension's location to the target table's schema: extensions are a
database-wide resource, and pinning `vector` to a per-app schema would
leave the unqualified `vector(N)` references in DDL unresolved.
"""
schema_clause = f' WITH SCHEMA "{pg_schema_name}"' if pg_schema_name else ""
await conn.execute(f"CREATE EXTENSION IF NOT EXISTS vector{schema_clause}")
await conn.execute("CREATE EXTENSION IF NOT EXISTS vector")

async def _create_table(
self,
Expand All @@ -989,7 +990,7 @@ async def _create_table(

# Ensure pgvector extension exists if needed by any column type.
if _schema_uses_pgvector(schema):
await self._ensure_pgvector_extension(conn, key.pg_schema_name)
await self._ensure_pgvector_extension(conn)

# Build column definitions
col_defs = []
Expand Down Expand Up @@ -1025,7 +1026,7 @@ async def _apply_column_actions(
for sub_key, action in column_actions.items():
if sub_key == _EXT_PGVECTOR_SUBKEY:
if action != "delete":
await self._ensure_pgvector_extension(conn, key.pg_schema_name)
await self._ensure_pgvector_extension(conn)
continue

if not sub_key.startswith(_COL_SUBKEY_PREFIX):
Expand Down
Loading