Fix Guestmem label and page-fault handler#1154
Open
joergroedel wants to merge 3 commits into
Open
Conversation
joergroedel
requested review from
00xc,
msft-jlange,
peterfang and
stefano-garzarella
as code owners
00xc
reviewed
Jul 3, 2026
luigix25
reviewed
Jul 3, 2026
00xc
added
the
needs-rebase
joergroedel
removed
the
needs-rebase
The label must point at the potentially faulting RIP in order for the exception to be handled correctly. Fix the label in copy_bytes(). Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
The page-fault handler did not handle faults to the user memory region correctly when they were coming from kernel code. Rewrite the handler to implement the right behavior. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Some structs in the ELF parser code miss the Copy + Clone annotations, so add them. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues and add missing
Copy + Cloneannotations to ELF code. The issues fixes here:copy_bytes()so it points to the instruction that will fault.