bldr: exclude from workspace clippy and simplify build script#1159
Open
luigix25 wants to merge 3 commits into
Open
bldr: exclude from workspace clippy and simplify build script#1159luigix25 wants to merge 3 commits into
luigix25 wants to merge 3 commits into
Conversation
luigix25
requested review from
00xc,
joergroedel,
msft-jlange,
peterfang and
stefano-garzarella
as code owners
00xc
reviewed
Jul 7, 2026
Collect the packages that require --target x86_64-unknown-none into a BARE_METAL_MEMBERS variable and loop over them instead of repeating each --exclude and --package invocation. This makes it easier to add or remove bare-metal crates in the future. Suggested-by: Carlos López <clopez@suse.de> Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
The bldr crate only targets x86_64-unknown-none. Running clippy with --workspace lints it against the host target, which can produce incorrect errors. Exclude it from the workspace invocation since it is already linted separately with the correct target. Reported-by: Arun Menon <armenon@redhat.com> Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
The build script only passed --build-id=none when the target was x86_64-unknown-none. Since bldr is only ever built for this target, the conditional is unnecessary. Remove it. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
Collaborator
Author
|
[@00xc]
|
00xc
approved these changes
Jul 7, 2026
|
Looks good to me. Thanks @luigix25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.rsfile, there is a check on the target, remove it for the same reason as above.cc @armenon-rh