boot_params: get debug com port from IGVM command line#1164
Draft
msft-jlange wants to merge 1 commit into
Draft
Conversation
The IGVM command line is intended to convey debug configuration options, so obtain the debug com port identifier from the command line instead of relying on a static configuration in the IGVM file. This eliminates one more hypervisor-specific difference from the IGVM file. If the command line is not specified (QEMU does not specify a command line), then the com port defaults to 1, which is the value that QEMU expects, thus ensuring that QEMU can get the correct behavior without requiring a command line to be specified. Signed-off-by: Jon Lange <jlange@microsoft.com>
msft-jlange
requested review from
00xc,
joergroedel,
peterfang and
stefano-garzarella
as code owners
Collaborator
Author
|
This PR requires a change to QEMU such that QEMU ignores the command line parameter directive instead of treating it as a fatal error. Since the kernel doesn't require any command line to be present, this is a safe change to QEMU, but it has to propagate before this PR can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IGVM command line is intended to convey debug configuration options, so obtain the debug com port identifier from the command line instead of relying on a static configuration in the IGVM file. This eliminates one more hypervisor-specific difference from the IGVM file. If the command line is not specified (QEMU does not specify a command line), then the com port defaults to 1, which is the value that QEMU expects, thus ensuring that QEMU can get the correct behavior without requiring a command line to be specified.