Fix PhysX wasm memory leak and update PhysX to 4.1.2.29882248 to memory overflow issues.#18420
Merged
dumganhar merged 11 commits intococos:v3.8.6from Mar 9, 2025
Merged
Conversation
…ry overflow issues.
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
dumganhar
commented
Mar 8, 2025
| export function getContactDataOrByteOffset (index: number, offset: number): any { | ||
| const gc = PX.getGContacts(); | ||
| const data = gc.get(index + offset); | ||
| gc.delete(); |
Contributor
Author
There was a problem hiding this comment.
getGContacts returns pointer now, so .delete() is not needed.
dumganhar
commented
Mar 8, 2025
| if(USE_PHYSICS_PHYSX) | ||
| if (ANDROID AND CMAKE_ANDROID_ARCH_ABI MATCHES x86) | ||
| set(USE_PHYSICS_PHYSX OFF) | ||
| message(AUTHOR_WARNING "Native PhysX does not support Google Android X86") |
Contributor
Author
There was a problem hiding this comment.
Support android x86 for physx now.
dumganhar
commented
Mar 8, 2025
| cd $GITHUB_WORKSPACE/templates/android/build | ||
| mkdir -p build-android/proj | ||
| touch build-android/proj/cfg.cmake | ||
| echo "set(USE_PHYSICS_PHYSX ON)" >> build-android/proj/cfg.cmake |
Contributor
Author
There was a problem hiding this comment.
CI should also build physx c++ backend.
Contributor
Author
|
@cocos-robot run test cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: