修正 UIOpacity 组件 在处理 localOpacity 和 _parentOpacity 时的若干错误 #18623
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
当父节点不存在时, _parentOpacity 需要还原为 1 .
否则 下次执行 UIOpacity 的 onEnable() 时,
还是用的之前的 _parentOpacity .
```ts
public onEnable (): void {
this.node.on(NodeEventType.PARENT_CHANGED, this._parentChanged, this);
// 这里用的还是 之前的 this._parentOpacity . _parentOpacityResetFlag 并没有发挥什么作用.
this.node._uiProps.localOpacity = this._parentOpacity * this._opacity / 255;
if (this._parentOpacityResetFlag) {
this._parentChanged();
this._parentOpacityResetFlag = false;
} else {
this._setEntityLocalOpacityRecursively(this.node._uiProps.localOpacity);
}
}
```
6 tasks
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
onDisable 中也要还原 _parentOpacity
finscn
changed the title
finscn
commented
Apr 16, 2025
| const render = this.node._uiProps.uiComp as UIRenderer; | ||
| if (render && render.color) { // exclude UIMeshRenderer which has not color | ||
| render.renderEntity.colorDirty = true; | ||
| render.renderEntity.localOpacity = opacity; | ||
| render.node._uiProps.localOpacity = opacity; | ||
| // render.node._uiProps.localOpacity = opacity; |
There was a problem hiding this comment.
render.node._uiProps.localOpacit 等价于 this.node._uiProps.localOpacity.
而 this.node._uiProps.localOpacity = opacity; 无论是否有 render 都需要被执行,
所以 移到前面去执行.
finscn
commented
Apr 16, 2025
| @@ -229,18 +233,20 @@ export class UIOpacity extends Component { | |||
|
|
|||
| public onEnable (): void { | |||
| this.node.on(NodeEventType.PARENT_CHANGED, this._parentChanged, this); | |||
| this.node._uiProps.localOpacity = this._parentOpacity * this._opacity / 255; | |||
| const opacity = this._opacity / 255; | |||
| this.node._uiProps.localOpacity = opacity; | |||
There was a problem hiding this comment.
在 非 JSB 环境, localOpacity 只与 this._opacity 有关.
finscn
commented
Apr 16, 2025
| } | ||
| } | ||
|
|
||
| public onDisable (): void { | ||
| this.node.off(NodeEventType.PARENT_CHANGED, this._parentChanged, this); | ||
| this.node._uiProps.localOpacity = 1; | ||
| this._setEntityLocalOpacityRecursively(this.node._uiProps.localOpacity); | ||
| this._parentOpacity = 1; | ||
| this._setEntityLocalOpacityRecursively(1); |
There was a problem hiding this comment.
这里直接用 1 就行. 没必要再执行那么长的代码
finscn
commented
Apr 16, 2025
| if (this._parentOpacityResetFlag) { | ||
| this._parentChanged(); | ||
| this._parentOpacityResetFlag = false; | ||
| } else { | ||
| this._setEntityLocalOpacityRecursively(this.node._uiProps.localOpacity); | ||
| this._setEntityLocalOpacityRecursively(this._parentOpacity * opacity); |
There was a problem hiding this comment.
_setEntityLocalOpacityRecursively 内的逻辑只有 jsb环境 才会被执行.
JSB 环境 下 此处需要传入 this._parentOpacity * this._opacity / 255
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当 onDisable 时, _parentOpacity 需要还原为 1 .
当 触发_parentChanged() 时, 如果父节点不存在 , _parentOpacity 也需要还原为 1 .
否则 下次执行 UIOpacity 的 onEnable() 时, 还是用的之前的 _parentOpacity .
另外 , onEnable 中,
this.node._uiProps.localOpacity = this._parentOpacity * this._opacity / 255这行本身就存在错误.#18624 在这里有讨论.
这个 PR 用来解决下列 BUG (原生平台):
此 bug 并非必现,取决于 spine 动画的某些特质 和 移动节点的时机 以及整个节点树的层级影响.
我实际项目中结构比上面的描述要复杂一些. 而且用到的节点池.
将某些spine 动画用完了,放到池子里, 下次从池子里取出并使用时 ,我发现某些动画会呈现半透明.
于是研究了一下, 当spine 动画节点放回到池子里时,它的父节点是半透明的, 即使放到池子里时, 我已经设置了spine 节点的 parent=null, 仍然会出现下次使用时, 透明度不正确的情况,
于是顺着这个线索研究了一下, 得到了此 PR里的结论.
根本原因还是 localOpacity 和 _parentOpacity 的错乱造成的.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: