Skip to content

A spec-compliance WebSocket implementation #18687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.8.7
Choose a base branch
from

Conversation

anonymous-12138
Copy link

@anonymous-12138 anonymous-12138 commented May 2, 2025

Re: #

Changelog

  • Remove existing WebSocket polyfills in platform/ since:
    • it's not align with spec,
    • it can't send ArrayBufferViews on wechat
  • Add a more spec-compliance WebSocket implementation in source
  • Add an engine feature called "WebSocket Exports" which exports WebSocket, CloseEvent, MessageEvent
  • Add an engine feature called "WebSocket shim" which polyfill the above symbols onto global.

I didn't test these on misc platforms but web/wechat.


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant