Skip to content

Refactor audio engine module, replace backend with OpenAL for android platform.#18958

Closed
halx99 wants to merge 5 commits into
cocos2d:v3from
halx99:v3
Closed

Refactor audio engine module, replace backend with OpenAL for android platform.#18958
halx99 wants to merge 5 commits into
cocos2d:v3from
halx99:v3

Conversation

@halx99
Copy link
Copy Markdown
Contributor

@halx99 halx99 commented Jul 23, 2018

No description provided.

@drelaptop
Copy link
Copy Markdown
Contributor

many checks failed, even Mac and iOS, strictly it should only have effect on android build.

@halx99
Copy link
Copy Markdown
Contributor Author

halx99 commented Jul 23, 2018

let's check.

@crazyhappygame
Copy link
Copy Markdown
Contributor

@halx99 what exactly is changed here? It seems like you touch all platforms. Is it possible to split to few smaller pull requests?

@halx99
Copy link
Copy Markdown
Contributor Author

halx99 commented Jul 23, 2018

You are right, I will split to few smaller pull requests.

@crazyhappygame
Copy link
Copy Markdown
Contributor

And what will be in those few smaller pull requests? :)

@halx99
Copy link
Copy Markdown
Contributor Author

halx99 commented Jul 23, 2018

Let's do android only.

@halx99 halx99 closed this Jul 23, 2018
@crazyhappygame
Copy link
Copy Markdown
Contributor

Why Android? What is wrong, what you would like to fix it?
We have problem with Linux fmod - is not open source. Could you start with Linux?

@halx99
Copy link
Copy Markdown
Contributor Author

halx99 commented Jul 24, 2018

@drelaptop see the new PR: #18961, BEFORE the 3rd party libs update, ci check can't sucess.
@crazyhappygame The original implentation of android does not support streaming mode, and have some issues, such as deadlock when play/stop music frequently. After finish android, may continue work for Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants