Skip to content

fix toupper function call #19705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2019
Merged

fix toupper function call #19705

merged 2 commits into from
May 16, 2019

Conversation

JohnCoconut
Copy link
Contributor

  • Original pointer cast does nothing, as it doesn't change signature
  • toupper arugment type should be unsigned char

Reference: https://en.cppreference.com/w/cpp/string/byte/toupper

@JohnCoconut
fix toupper function call
ad5dbb2 
* Original pointer cast does nothing, as it doesn't change signature
* toupper arugment type should be unsigned char

Reference: https://en.cppreference.com/w/cpp/string/byte/toupper
@minggo
Copy link
Contributor

minggo commented May 14, 2019 

  C:\projects\cocos2d-x\cocos\renderer\CCRenderState.cpp(485): error C2039: 'toupper': is not a member of 'std' [C:\projects\cocos2d-x\win32-build\engine\cocos\core\cocos2d.vcxproj]

Miss including header files on windows.

@minggo minggo added this to the next milestone May 16, 2019
@minggo minggo merged commit 9548d4e into cocos2d:v3 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnCoconut @minggo