use okhttp3 #19706
Closed
use okhttp3 #19706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggo
reviewed
May 15, 2019
| else | ||
| downloader.onFinish(id, ErrorCode.ERROR_IMPL_INTERNAL, errStr, null); | ||
| } else { | ||
| // 非文件 |
|
why not use curl for all platforms? |
|
@halx99 according the issue: #10382, i think it is about to reduce package size. Use platform network can reduce the package size. But it is pity that it brings JAR lib on Android too, though the package size is smaller than libcurl(curl depends on ssl). So i think it will be better if not 3rd party library is needed. |
PatriceJiang
force-pushed
the
use-ok-http3
branch
from
5edbe9c to
5a1f199
Compare
|
re-commit in #19766 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
okhttpto replaceandroid-async-httpin CCDownloader android implementation.base on cocos/engine-native#1731