Skip to content

the label's dimensions are now set to 98% the width of the button #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,8 @@ cocos2d::Node* CreatorReader::createTree(const buffers::NodeTree* tree) const
auto button = static_cast<cocos2d::ui::Button*>(node);
auto label = static_cast<cocos2d::Label*>(child);
button->setTitleLabel(label);

label->setDimensions(button->getContentSize().width*.98f, 0);
}
else
{
Expand Down Expand Up @@ -965,6 +967,9 @@ cocos2d::ui::Button* CreatorReader::createButton(const buffers::Button* buttonBu

void CreatorReader::parseButton(cocos2d::ui::Button* button, const buffers::Button* buttonBuffer) const
{
//NOTE that the title renderer is added after this, in parseTree, where we set its
// location and dimensions based on the parent button

const auto& nodeBuffer = buttonBuffer->node();
parseNode(button, nodeBuffer);

Expand Down