Skip to content

fix: add sha prefix to versioning #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025
Merged

fix: add sha prefix to versioning #105

merged 6 commits into from
May 28, 2025

Conversation

CallMeLeopoldo
Copy link
Contributor

@CallMeLeopoldo CallMeLeopoldo commented May 6, 2025

This fix is to solve the invalid semver versioning pointed in the ticket [GH#53]

@CallMeLeopoldo CallMeLeopoldo requested a review from lolgab as a code owner May 6, 2025 10:05
@lolgab
Copy link
Contributor

lolgab commented May 6, 2025

Can you add a unit test for what you want to fix?
We have a nice test setup here, so it should be fairly easy.

lolgab
lolgab previously approved these changes May 15, 2025
lolgab
lolgab previously approved these changes May 15, 2025
@CallMeLeopoldo CallMeLeopoldo merged commit ac0f426 into master May 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants