Update usage of IInstructionWithData
#336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfd1934 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Nice, thanks for this! |
| {% endif %} | ||
| {% if hasData %} | ||
| & IInstructionWithData<Uint8Array> | ||
| & IInstructionWithData<ReadonlyUint8Array> |
Contributor
There was a problem hiding this comment.
Nice! I think this is the solution to the type error here, right? https://codesandbox.io/p/sandbox/dfsktf
Member
Author
There was a problem hiding this comment.
That's right! I think this is ready to be merged actually since I believe the required changes are bundled in the latest Solana Kit version.
Member
Author
|
Closing in favour of #714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Codama and the code it generates for the new web3.js to be compatible with the latest
IInstructionWithDatachange introduce in solana-foundation/solana-web3.js#3632.Note that, we need to wait for
2.1.0to be published before merging this PR since, otherwise, we will be using a canary version in our dependencies.