Skip to content

Conversation

@daog1
Copy link
Contributor

@daog1 daog1 commented May 29, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2025

🦋 Changeset detected

Latest commit: 434ef2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@codama/nodes-from-anchor Patch
@codama/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@sonicfromnewyoke sonicfromnewyoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lorisleiva
Copy link
Member

Thanks! I can update the PR when I'm back on Monday to add tests and try to reuse the parsed accounts to fix this.

That is going to be a good solution for static account infos but still doesn't fix the case where the program ID seed is linked to an account or argument we don't know at compile time.

@lorisleiva lorisleiva changed the title fix 607 Recognize program address from Anchor IDL with seed of kind "account" Jun 13, 2025
Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Again, this doesn't fix #607 fully but it is a step in the right direction.

@lorisleiva lorisleiva merged commit 14aeb2d into codama-idl:main Jun 13, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants