refactor(renderers-vixen-parser): replace solana-program with more granular crates
#685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a7f9859 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sonicfromnewyoke
changed the title
solana-program with more granular cratessolana-program with more granular crates
Contributor
|
I just had a 1st look at this, it's looking good. My only question is, if we update this in the vixen generator but not on the rust sdk generator will not cause cargo issues? |
Contributor
Author
fernandodeluret
approved these changes
Jul 10, 2025
Contributor
fernandodeluret
left a comment
fernandodeluret
left a comment
There was a problem hiding this comment.
Thanks for the clarification. LGTM this is exactly what we discussed, thanks for the contribution ❤️
lorisleiva
approved these changes
Jul 10, 2025
Member
|
Thank you! @fernandodeluret are you happy for me to publish a new version now (this will be a minor bump according to the changeset of this PR)? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
renderers-vixen-parseruse bloatedsolana-programcrateSolution
replace
solana-programwithsolana-*crates to make deps more granular, agreed in #616cc @fernandodeluret