My implementation of extra buttons requested by issue 2743 #2863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the feature requested in #2743 and merged the "player fit to win button" with the newly added button into a submenu called "Extra buttons inside the player."
This might be a bit off-topic, but during debugging, I noticed that the "player fit to win button" toggle only works once (i.e., if I toggle this option multiple times on the same page, it works as expected the first time—creating and hiding the corresponding button in the bottom right corner of the video—but subsequent toggles fail to work properly). I suspect this is related to an issue encountered during development: buttons created using the
createPlayerButton
API do not display correctly unlessit-player-button
class is removed.