Skip to content

My implementation of extra buttons requested by issue 2743 #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lainadux
Copy link

I implemented the feature requested in #2743 and merged the "player fit to win button" with the newly added button into a submenu called "Extra buttons inside the player."
This might be a bit off-topic, but during debugging, I noticed that the "player fit to win button" toggle only works once (i.e., if I toggle this option multiple times on the same page, it works as expected the first time—creating and hiding the corresponding button in the bottom right corner of the video—but subsequent toggles fail to work properly). I suspect this is related to an issue encountered during development: buttons created using the createPlayerButton API do not display correctly unless it-player-button class is removed.

@ImprovedTube
Copy link
Member

our structure is redundant (considering this could be at any position and also is at shortcuts)
(Feature/function: Seek, Duration: X; Shortcut: Y; Button (Position: Controls, right) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants