Skip to content

fix: video filters button setting hidden when Screenshot is disabled - #4373

Merged
ImprovedTube2 merged 1 commit into
code-charity:masterfrom
hkzo:fix/video-filters-button-menu
Oct 9, 2026
Merged

ImprovedTube2 merged 1 commit into
code-charity:masterfrom
hkzo:fix/video-filters-button-menu

Conversation

@hkzo

@hkzo hkzo commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

The Video Filters button setting is currently hidden when Screenshot is disabled. This PR moves it after Save as so it remains accessible independently of Screenshot.

Related to #4112.

Screenshots

Before (Original)

Screenshot: ON Screenshot: OFF
image image
Subtitle & Save as are correct child options Subtitle & Save as are hidden

Current bug on master

Screenshot: ON Screenshot: OFF
image image
Video Filters button wrongly becomes a child option,
breaking Subtitle & Save as hierarchy
Video Filters button is hidden

Changes

  • Move player_video_filters_button after player_screenshot_save_as in menu/skeleton-parts/player.js.
  • Restore the order of Screenshot and its dependent settings: Screenshot, subtitle capture, and Save as, followed by Video Filters button.
Screenshot: ON Screenshot: OFF
image image

Why

#4112 inserted the Video Filters button setting immediately after Screenshot. Existing rules in menu/styles/sub-options.css hide the switch immediately following Screenshot when Screenshot is disabled. As a result, those rules hide the Video Filters button setting instead of the subtitle capture setting. The Save as setting also stops matching its existing conditional CSS selector.

Moving Video Filters button after Save as restores the intended relationship between Screenshot and its dependent settings, and keeps the video filters button setting accessible independently of Screenshot. The existing CSS then applies visibility, indentation, and background styling to the correct controls.

Testing

  • Confirmed that the Video Filters button setting remains visible whether Screenshot is enabled, disabled, or unset.
  • Confirmed that subtitle capture and Save as are shown only when Screenshot is enabled, with the expected indentation and background styling.
  • Confirmed that both playback speed sliders still follow the playback speed button toggle.
  • JavaScript syntax and git diff --check checks passed.

Notes

I used AI assistance only for translating this PR description.

@hkzo

hkzo commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

After opening this PR, I submitted a follow-up report indicating that the Video Filters feature itself is not working. See #4374

@ImprovedTube2
ImprovedTube2 merged commit f9d850a into code-charity:master Oct 9, 2026
1 check passed
@hkzo
hkzo deleted the fix/video-filters-button-menu branch October 9, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants