Repository navigation
fix: video filters button setting hidden when Screenshot is disabled - #4373
Merged
ImprovedTube2 merged 1 commit intoOct 9, 2026
Merged
Conversation
Collaborator
Author
|
After opening this PR, I submitted a follow-up report indicating that the Video Filters feature itself is not working. See #4374 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Video Filters button setting is currently hidden when Screenshot is disabled. This PR moves it after Save as so it remains accessible independently of Screenshot.
Related to #4112.
Screenshots
Before (Original)
Current bug on master
breaking Subtitle & Save as hierarchy
Changes
player_video_filters_buttonafterplayer_screenshot_save_asinmenu/skeleton-parts/player.js.Why
#4112 inserted the Video Filters button setting immediately after Screenshot. Existing rules in
menu/styles/sub-options.csshide the switch immediately following Screenshot when Screenshot is disabled. As a result, those rules hide the Video Filters button setting instead of the subtitle capture setting. The Save as setting also stops matching its existing conditional CSS selector.Moving Video Filters button after Save as restores the intended relationship between Screenshot and its dependent settings, and keeps the video filters button setting accessible independently of Screenshot. The existing CSS then applies visibility, indentation, and background styling to the correct controls.
Testing
git diff --checkchecks passed.Notes
I used AI assistance only for translating this PR description.