Repository navigation
Conversation
|
|
||
| if (trustedFetchedDocument || this._isCurrentDomVerified(doc, expectedVideoId)) { | ||
| // Do not read meta[name="keywords"]; YouTube may populate it with generic | ||
| // defaults that are not reliable video-specific keywords. |
There was a problem hiding this comment.
There was a problem hiding this comment.
I understand that logic, but since default keywords are localized, they would become noise outside of English-speaking regions, so I decided not to adopt them from meta. For example, in Japanese, the default keywords become "動画,ビデオ,共有,カメラ付き携帯電話,動画機能付き携帯電話,無料,アップロード,チャンネル,コミュニティ,YouTube,ユーチューブ".
|
unverified LLM comment:
|
Yes. Retained for lazy parsing of the "fetched DOM" used as the final fallback for title, genre, duration, and lengthSeconds.
Consider earlier release.
That's correct. If fetching fails and no values can be obtained from other sources, it is currently cached as |
- Distinguish between 'not-found' and source-specific errors (network/DOM parsing failures) to improve observability. - Stop storing raw HTML in memory by default to reduce memory footprint (retained only in debug mode). - Rename SOURCE_PRIORITY_WITH_DOM to SOURCE_PRIORITY_PLAYER_AND_DOM to clarify source composition. - Minor cleanup and adjustments.
- Move maxEntries and maxAgeMs default values from `gc()` to `ImprovedTube.VideoMetadata` - Update default maxEntries from 50 to 100 - Update JSDoc for `gc` method to reflect new default value
Summary of Changes
|
92b159b to
bac4723
Compare
|
Updated the PR description to reflect the added support for YouTube Shorts. |
bac4723 to
0319e33
Compare
Summary
Currently, multiple player features inside
player.jsmaintain their own YouTube video metadata lookup logic. This leads to code duplication and makes individual features harder to follow.Since we made significant feature enhancements and architectural overhauls from the previous PR (#4154), we are resetting this as a brand-new PR rather than continuing the old one.
Key Changes
videoId, not just the currently playing video.Map) for each videoId. Old data is removed viagc().uploadDate.Design / Implementation Direction
VideoMetadataprovides metadata and marker inputs; it does not decide whether a video is music, where to seek, or how Smart Speed should behave.getDataAsync(), etc.).Testing / Current Status
jumpToKeyScene()by using this feature for reference.playerPlaybackSpeedwill be submitted in a separate PR (due to existing issues on the current master branch).LLM disclosure