Repository navigation
fix(sidebar): show the collapsed related videos bar on dark theme - #4475
Merged
Merged
Conversation
--yt-spec-text-primary is not defined for the watch page sidebar anymore, so the show more bar inherited black text on the dark background and the sidebar looked empty. fall back to youtube's current text color when no theme sets the variable.
Member
|
hi and thank you for the backup! @tridev-tej |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with related videos set to collapsed, the show more bar is black text on youtube's dark background, so the sidebar looks empty. --yt-spec-text-primary isn't defined for the watch page sidebar anymore, so the color drops to black. now it uses youtube's --yt-sys-color-baseline--text-primary when no extension theme sets the old variable. reproduced on dark theme in chrome; after the change the bar reads #f1f1f1 on dark and #0f0f0f on light.
Fixes #4474