Skip to content

Menu: even layout for the home screen (bubbles and list) - #4480

Open
workingwithkwan wants to merge 2 commits into
code-charity:masterfrom
workingwithkwan:claude/popup-home-grid
Open

workingwithkwan wants to merge 2 commits into
code-charity:masterfrom
workingwithkwan:claude/popup-home-grid

Conversation

@workingwithkwan

Copy link
Copy Markdown

What this changes

The home screen of the menu shows its nine categories in three tiers of sizes, in both layouts. This makes both layouts even.

  • Bubbles: a grid of three columns with circles of one size (60px). Before, the rows had 3, 4 and 2 buttons with circles of 60, 55 and 47px, so the columns did not line up.
  • List: one column of nine rows of one size (30px, icons 20px). Before, Blocklist and Analyzer were scaled down and squeezed in at the right of the last two rows.
  • Hidden categories: the remaining ones simply fill the grid or list. Before, hiding e.g. Themes and Blocklist pushed the Analyzer bubble beyond the right edge of the popup.

How

  • The per-category scale / margin rules at the top of menu/satus.css are removed.
  • menu/styles/home.css gets one rule for the list rows (all nine categories) and 8px less height per row of bubbles, so that the third row stays clear of the panel at the bottom of the popup.

The tiers looked intentional, so I understand if you prefer to keep them; the off-screen bubble when categories are hidden could then be fixed on its own.

Testing

  • Manually tested on latest Firefox, Windows.
  • In Chromium at the popup's size (320x584) with the extension loaded: both layouts, light and dark, and with categories hidden. Circle sizes, row heights and positions were measured from the page.
  • New unit test tests/unit/home-screen-layout.test.js; the full suite passes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VnPaaESvf1EA3kfaCTrKV6

The category buttons of the home screen (layout "bubbles") had three
rows of 3, 4 and 2 buttons with circles of 60, 55 and 47px, so the
columns did not line up. Hiding some categories could also push a
button outside the popup (e.g. hide Themes and Blocklist: Analyzer
ended up beyond the right edge).

They are now a grid of three columns with circles of one size (60px).
Hidden categories simply leave the grid shorter.

- satus.css: the per-category scale/margin rules now only apply to the
  "list" layout, which looks exactly as before.
- home.css: 8px less height per row, so the third row stays clear of
  the panel at the bottom of the popup.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VnPaaESvf1EA3kfaCTrKV6
The "list" layout of the home screen had the same three tiers as the
bubbles: General, Player and Appearance in full-size rows, four smaller
rows below, and Blocklist and Analyzer scaled down and squeezed in at
the right of the last two rows.

It is now one column of nine rows of one size (30px, icons 20px), which
still fits above the panel at the bottom of the popup.

The per-category rules at the top of satus.css are gone; home.css has
one rule for all nine categories.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VnPaaESvf1EA3kfaCTrKV6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants