Repository navigation
Menu: even layout for the home screen (bubbles and list) - #4480
Open
workingwithkwan wants to merge 2 commits into
Open
workingwithkwan wants to merge 2 commits into
workingwithkwan wants to merge 2 commits into
Conversation
The category buttons of the home screen (layout "bubbles") had three rows of 3, 4 and 2 buttons with circles of 60, 55 and 47px, so the columns did not line up. Hiding some categories could also push a button outside the popup (e.g. hide Themes and Blocklist: Analyzer ended up beyond the right edge). They are now a grid of three columns with circles of one size (60px). Hidden categories simply leave the grid shorter. - satus.css: the per-category scale/margin rules now only apply to the "list" layout, which looks exactly as before. - home.css: 8px less height per row, so the third row stays clear of the panel at the bottom of the popup. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VnPaaESvf1EA3kfaCTrKV6
The "list" layout of the home screen had the same three tiers as the bubbles: General, Player and Appearance in full-size rows, four smaller rows below, and Blocklist and Analyzer scaled down and squeezed in at the right of the last two rows. It is now one column of nine rows of one size (30px, icons 20px), which still fits above the panel at the bottom of the popup. The per-category rules at the top of satus.css are gone; home.css has one rule for all nine categories. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VnPaaESvf1EA3kfaCTrKV6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The home screen of the menu shows its nine categories in three tiers of sizes, in both layouts. This makes both layouts even.
How
menu/satus.cssare removed.menu/styles/home.cssgets one rule for the list rows (all nine categories) and 8px less height per row of bubbles, so that the third row stays clear of the panel at the bottom of the popup.The tiers looked intentional, so I understand if you prefer to keep them; the off-screen bubble when categories are hidden could then be fixed on its own.
Testing
tests/unit/home-screen-layout.test.js; the full suite passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01VnPaaESvf1EA3kfaCTrKV6