Repository navigation
Conversation
Adds a Bookmarks button under the player and a panel that saves named timestamps per video. Bookmarks can be jumped to, deleted, and exported as TXT or JSON. Off by default; no network requests and no new permissions.
chirag127
marked this pull request as ready for review
November 18, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4097.
What this adds
A Bookmarks button under the player on any watch page, and a panel that stores named timestamps for that video.
chrome.storage.localunderbookmarks, so it survives reloads and follows the browser profilebookmarks_enabled); nothing is drawn until the switch is onWhere it lives
js&css/web-accessible/www.youtube.com/features/bookmarks.jsmenu/skeleton-parts/bookmarks.js_locales/en/messages.jsonmanifest.jsonweb_accessible_resourcesentryjs&css/extension/init.jspageWorldFilesmenu/index.htmltests/unit/bookmarks.test.jsNo existing feature file is edited. The module registers itself on
init_completed/yt-navigate-finish, so it does not depend on the order of the other feature scripts.Verification
Live check: the module was injected into a real
youtube.com/watchpage in Chrome 157. Clicking the button opened the panel, submitting the form at1:05producedand the panel rendered a
1:05 chorusrow whose click setsvideo.currentTime. Screenshot:Not tested
Blobandchrome.storagethrough the existing bridge.Conflicts
Checked against the 160 open PRs: none touches
features/bookmarks.js,menu/skeleton-parts/bookmarks.js, ortests/unit/bookmarks.test.js. The shared-file edits are one added line each. Default off, so it changes nothing for existing users.